Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported Document - Poorly Formated Code Blocks #4215

Closed
lue30499 opened this issue May 3, 2023 · 2 comments
Closed

Exported Document - Poorly Formated Code Blocks #4215

lue30499 opened this issue May 3, 2023 · 2 comments
Labels
🐛 Bug
Milestone
v23.05.1

Comments

@lue30499
Copy link

lue30499 commented May 3, 2023

Describe the Bug

The code blocks of an existing document when exported as PDF and HTML has the text behind the left number bar without numbers.

Steps to Reproduce

  1. Go to existing document
  2. Click export
  3. View export
  4. Observe incorrect format

Expected Behaviour

  1. Go to existing document
  2. Click export
  3. View export
  4. Observe correct format

Screenshots or Additional Context

HTML Export:

image

PDF Export:

image

Browser Details

Chrome 112.0.5615.165

Exact BookStack Version

v23.05

PHP Version

8.1.2-1ubuntu2.11

Hosting Environment

Proxmox LXC Ubuntu 22.04.2 LTS
@ssddanbrown ssddanbrown added this to the v23.05.1 milestone May 3, 2023
@ssddanbrown
Copy link
Member

Thanks for reporting @lue30499, Could definitely see this being due to changes I made for the latest release.
Have assigned to the next patch release.

ssddanbrown added a commit that referenced this issue May 8, 2023
@ssddanbrown
Fixed code block line-number bar showing in exports
4489f65 
Also fixed in print view.
Likely crept in during CM6 changes.

For #4215
@ssddanbrown
Copy link
Member

This has now been addressed in 4489f65, and will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Milestone
v23.05.1
Development

No branches or pull requests
2 participants
@ssddanbrown @lue30499