Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new header bar partials for easier customization #4564

Closed
ssddanbrown opened this issue Sep 19, 2023 · 1 comment
Closed

Create new header bar partials for easier customization #4564

ssddanbrown opened this issue Sep 19, 2023 · 1 comment
Labels
📖 Docs Update 🖌️ View Customization
Milestone
v23.10 - Maintenance

Comments

@ssddanbrown
Copy link
Member

Seems common to tweak the header bar (header.blade.php).
Probably worth splitting this down to extra components, with at least:

  • View for existing links/buttons.
  • Empty view at the start of existing links/button specifically for customization.
    • This would need test to cover like existing customization-only views.
  • Could maybe split out logo and search. Not sure there's much desire, but would allow easier moving/removal within header.blade.php overrides.

Already exacted profile menu in b90033a, might be worth thinking through organisation though, rather than bloating common.
@ssddanbrown ssddanbrown mentioned this issue Sep 19, 2023
Closed
1 task
ssddanbrown added a commit that referenced this issue Sep 24, 2023
@ssddanbrown
Header: Simplified, split and re-orgranised view file(s)
d5a3bdb 
- Moved "common" template partials, that are only used in layouts, to
  layouts/parts folder.
- Simplified HTML structure of header template.
- Extracted logo and links from header template to simplify.
- Added header-links-start template for easier extension/customization
  without needing to override full list of links.
  - Added test to cover usage of this.

For #4564
@ssddanbrown
Copy link
Member Author

Changes made in d5a3bdb.

New header link extension view at layouts/parts/header-links-start.blade.php.

While not a change to our official supported API, might be polite to warn about changes to the common/header.blade.php (Moved and changed) in update notes since this may have been a common customization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📖 Docs Update 🖌️ View Customization
Milestone
v23.10 - Maintenance
Development

No branches or pull requests
1 participant
@ssddanbrown