Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill Internal Link/Entity Select Search With Selected Text #4571

Closed
1 task done
aswgxf opened this issue Sep 21, 2023 · 2 comments
Closed
1 task done

Prefill Internal Link/Entity Select Search With Selected Text #4571

aswgxf opened this issue Sep 21, 2023 · 2 comments

Comments

@aswgxf
Copy link

aswgxf commented Sep 21, 2023

Describe the feature you'd like

I am currently going through some pages and adding links to other pages in BookStack. To try to quickly create these links, I am selecting the text I want to use for the link then using the keyboard shortcut ctrl+shift+k to bring up the Entity Select dialog to search for the page I want to link to. I was thinking it'd be nice to prefill the search dialog with the selected text.

To prevent interfering with existing workflows, the prefilled text could also be preselected in the search dialog so users who don't want to use the prefilled text can just start typing to do a new search.

For example, if I select the words "Frequently Asked Questions" in the following text and open the Entity Select dialog:
"For more information, check out the Frequently Asked Questions page."
I would like this result:
image

Describe the benefits this would bring to existing BookStack users

This would make it much quicker to add links to other pages on the site. I wouldn't consider it an essential feature to add, but it would be a nice QOL improvement

Can the goal of this request already be achieved via other means?

No

Have you searched for an existing open/closed issue?

  • I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?

3 months to 1 year

Additional context

No response

@ssddanbrown
Copy link
Member

Thanks @aswgxf,
I quite like this idea as a nice UX improvement, and shouldn't be too tricky to add, at least when accessed via Keyboard.
Have assigned to the next feature release with intent to implement.

ssddanbrown added a commit that referenced this issue Sep 24, 2023
Updated all uses across both editors, so the entity link selector popup
now initates a search with the selection text if existing.

For #4571
@ssddanbrown
Copy link
Member

This has been added to all use of the selector popup within both editors via commit 21badde.
This will be part of the next feature release.

Thanks again @aswgxf for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants