Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor toolbox icons not visible when selected while using dark app theme color on dark mode #4630

Closed
reddexx opened this issue Oct 30, 2023 · 6 comments
Labels
Milestone

Comments

@reddexx
Copy link

reddexx commented Oct 30, 2023

Describe the Bug

In Edit Mode Right Side
image

Steps to Reproduce

Go To Edit Mod with Dark Mode

Expected Behaviour

Empty Icon see

Screenshots or Additional Context

No response

Browser Details

Chrome

Exact BookStack Version

23.10

@ssddanbrown
Copy link
Member

Thanks for reporting @reddexx.
I'm assuming you have a dark primary app color (header bar color) set for dark mode?

I've used the primary color here but the link color may be more appropriate instead.

@reddexx
Copy link
Author

reddexx commented Oct 30, 2023

yes is the Primary Color

image

@reddexx
Copy link
Author

reddexx commented Oct 30, 2023

I have change this CSS

.floating-toolbox .tabs-inner>button:hover, .floating-toolbox.open .tabs-inner>button.active {
background-color: var(--color-primary-light);
color: #fff9f9;
border-bottom: 1px solid #000;
border-top: 1px solid #000;
}

unfortunately the declaration is often bound with many ID, see GIF
chrome_0K9md135Tk

@reddexx
Copy link
Author

reddexx commented Oct 30, 2023

@ssddanbrown this Working

.floating-toolbox .tabs-inner>button:active, .floating-toolbox.open .tabs-inner>button.active {
background-color: var(--color-primary-light);
color: #fff9f9;
border-bottom: 1px solid #000;
border-top: 1px solid #000;
}
chrome_4NeeCM7hFp

@ssddanbrown ssddanbrown added this to the v23.10.1 milestone Oct 30, 2023
@ssddanbrown ssddanbrown changed the title Empty icon in Darkmode? Editor toolbox icons not visible when selected while using darkapp theme color on dark mode Oct 30, 2023
@ssddanbrown ssddanbrown changed the title Editor toolbox icons not visible when selected while using darkapp theme color on dark mode Editor toolbox icons not visible when selected while using dark app theme color on dark mode Oct 30, 2023
@ssddanbrown
Copy link
Member

yes is the Primary Color

Thanks for confirming. I've assigned to the next patch release, with an aim to just use the link color instead of the primary app color (Or a lighter grey as demoed above if that does not suit).

ssddanbrown added a commit that referenced this issue Nov 2, 2023
Change due to link color being more suitable in this case since it's not
specifically a block with light text which is what app color is suited
for.
Specifically better for dark mode when a dark app color is used.

For #4630
@ssddanbrown
Copy link
Member

This has now been addressed within 02d1401, to be part of the next patch release.

Thanks again for reporting @reddexx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants