Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment upload validation error message appears are shown as JSON #4996

Closed
ssddanbrown opened this issue May 12, 2024 · 5 comments
Closed

Attachment upload validation error message appears are shown as JSON #4996

ssddanbrown opened this issue May 12, 2024 · 5 comments
Labels
🐛 Bug 💻 Front-End
Milestone
v24.05.1

Comments

@ssddanbrown
Copy link
Member

Can reproduce via uploading a file larger than the app upload limit.
Could do with reducing line-height here to provide more room for text too.

image
@ssddanbrown ssddanbrown added this to the v24.05.1 milestone May 12, 2024
@KiDxS
Copy link
Contributor

KiDxS commented May 18, 2024

Hey @ssddanbrown,

Can I work on this issue?

@ssddanbrown
Copy link
Member Author

@KiDxS Sure! But only if you're able to do so fairly soon (by the end of tomorrow) since this is assigned to the next patch already which I'm hoping to release soon, otherwise I'll take it back on.

@KiDxS
Copy link
Contributor

KiDxS commented May 18, 2024

Thanks for letting me know, Dan!

I'll start working on it after I get home in 2 hours.

If I don't finish it by the end of tomorrow. Feel free to take it back on.

@KiDxS
Copy link
Contributor

KiDxS commented May 18, 2024

Hi @ssddanbrown ,

I don't think I can fix this by the end of tomorrow.

I think I bit more than I can chew.

Feel free to take it back on.

ssddanbrown added a commit that referenced this issue May 18, 2024
@ssddanbrown
File Uploads: Added basic validation response formatting
72c5141 
Tested via app-level validation file limit, and then also with nginx
file post limit.
For #4996
@ssddanbrown
Copy link
Member Author

Thanks for updating me @KiDxS.
I've now addressed this via 72c5141, to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 💻 Front-End
Milestone
v24.05.1
Development

No branches or pull requests
2 participants
@ssddanbrown @KiDxS