You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When editing a Role and linking it to multiple External Authentication IDs, you may extend the 200 character length the field has in the database. When this happens, no error is shown. Instead, the string is silently truncated.
Steps to Reproduce
Open Role
Add more than 200 characters
Save
Open Role
Only 200 characters are present
Expected Behaviour
One could argue it should be possible to add more than 200 characters, as you can enter a list of any number of external ids.
But at least there should be a warning, that the string is being truncated. The user won't recognize this otherwise.
Screenshots or Additional Context
No response
Browser Details
Firefox 24.02.3 Windows 10
Exact BookStack Version
v24.02.3
The text was updated successfully, but these errors were encountered:
Thanks for reporting @cdrfun, this has been patched in bddc6ae to be part of the next release to add validation for this.
During editing, I found that the existing max was 180, not 200. If you're confident it's 200 in your environment (and that's non-modified from default) please let me know as I'd need to do some further investigation.
Ah, okay, I think instances created between 2018 and mid 2021 would have 200 here instead of 180.
Not sure best approach, I don't want to add a whole lot of field-checking complexity to the validation step where this may affect such a narrow scenario. Right now, saving with 180 - 200 on those instances will show validation warnings to users, but the value would remain unless provided under 180 chars.
If that's a significant issue to some we could change the field if really needed.
Describe the Bug
When editing a Role and linking it to multiple External Authentication IDs, you may extend the 200 character length the field has in the database. When this happens, no error is shown. Instead, the string is silently truncated.
Steps to Reproduce
Expected Behaviour
One could argue it should be possible to add more than 200 characters, as you can enter a list of any number of external ids.
But at least there should be a warning, that the string is being truncated. The user won't recognize this otherwise.
Screenshots or Additional Context
No response
Browser Details
Firefox 24.02.3 Windows 10
Exact BookStack Version
v24.02.3
The text was updated successfully, but these errors were encountered: