Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different line height between light and dark mode #5146

Closed
mehmet-b-90 opened this issue Aug 1, 2024 · 2 comments
Closed

Different line height between light and dark mode #5146

mehmet-b-90 opened this issue Aug 1, 2024 · 2 comments
Labels
🎨 Design 🐛 Bug 💻 Front-End
Milestone
v24.10.3

Comments

@mehmet-b-90
Copy link

Describe the Bug

I have noticed that the light and dark modes are displayed with different line heights in code blocks.

Steps to Reproduce

  1. Click Dark Mode
  2. Click Light Mode

Expected Behaviour

Equal line heights.

Screenshots or Additional Context

image

Browser Details

Vivaldi Browser 6.8

Exact BookStack Version

24.05.3
@mehmet-b-90
Copy link
Author

mehmet-b-90 commented Aug 1, 2024 •
edited
Loading

image

@ssddanbrown ssddanbrown added this to the v24.10.2 milestone Nov 28, 2024
ssddanbrown added a commit that referenced this issue Nov 29, 2024
@ssddanbrown
Code: Set base codemirror line height
4630f07 
Prevents difference in line height between light/dark mode.
For #5146
@ssddanbrown
Copy link
Member

Thanks for reporting @mehmet-b-90.
This has bee addressed in 4630f07, and is due to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 Design 🐛 Bug 💻 Front-End
Milestone
v24.10.3
Development

No branches or pull requests
2 participants
@ssddanbrown @mehmet-b-90