Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot update profile if your SSO name is 1 character long #5263

Closed
trwnh opened this issue Oct 15, 2024 · 1 comment
Closed

Cannot update profile if your SSO name is 1 character long #5263

trwnh opened this issue Oct 15, 2024 · 1 comment
Labels
🐛 Bug 🏭 Back-End
Milestone
v24.10.1

Comments

@trwnh
Copy link

trwnh commented Oct 15, 2024

Describe the Bug

Updating your Bookstack profile picture is not possible as long as your name is less than 2 characters.

Steps to Reproduce

  1. Log into Bookstack with SSO while your SSO name is 1 character long
  2. Try to update your profile picture

Expected Behaviour

Updating my profile picture should work, but it doesn't.

Screenshots or Additional Context

I get an error message "The name must be at least 2 characters." when trying to update my profile picture.

Browser Details

Firefox 132 on Arch Linux

Exact BookStack Version

24.10
@trwnh trwnh added the 🐛 Bug label Oct 15, 2024
ssddanbrown added a commit that referenced this issue Oct 15, 2024
@ssddanbrown
Users: Changed name validation to min:1 instead of 2
6f1c54d 
Would cause scenarios where users could be created with 1 char, but then
fail to update due to validation differences.
Added test to cover.
For #5263
@ssddanbrown ssddanbrown added this to the v24.10.1 milestone Oct 15, 2024
@ssddanbrown
Copy link
Member

Thanks for reporting @trwnh, don't see any reason to have a minimum of 2 rather than 1, so have changed this in 6f1c54d to be part of the next patch release.

johnroyer pushed a commit to johnroyer/BookStack that referenced this issue Oct 29, 2024
@ssddanbrown @johnroyer
Users: Changed name validation to min:1 instead of 2
ece3366 
Would cause scenarios where users could be created with 1 char, but then
fail to update due to validation differences.
Added test to cover.
For BookStackApp#5263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 🏭 Back-End
Milestone
v24.10.1
Development

No branches or pull requests
2 participants
@ssddanbrown @trwnh