Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for word only works if put inside "" #531

Closed
DagW opened this issue Sep 28, 2017 · 5 comments
Closed

Searching for word only works if put inside "" #531

DagW opened this issue Sep 28, 2017 · 5 comments

Comments

@DagW
Copy link

DagW commented Sep 28, 2017

For Bug Reports

  • BookStack Version: v0.18.1
  • PHP Version:
  • MySQL Version:

I added some text about trello,
tried to search for 'trello' -> No matches
tried to search for '"trello"' -> 1 match

Expected Behavior

To find the trello word without qoutes

Actual Behavior

Did not find the word

@ssddanbrown
Copy link
Member

Hi @DagW, Thanks for raising this issue. In your content, is trello a word by itself (With only spaces around it) or is it part of more text such as trello-cat or mytrello?

@DagW
Copy link
Author

DagW commented Sep 29, 2017

" trello " would be a word by itself, with spaces around it.
Also if the line starts with "trello "
Thanks, love the app otherwise. Im trying to work it in as the main documentation platform :-)

@ssddanbrown
Copy link
Member

After a deeper dive it looks like there were some indexing issues when words are at the start of a line or when after tabs.

I've updated the indexing to be smarter, Will be part of the next bugfix release (Hopefully deploying sometime this weekend).

Let me know after the update if this does not fix your issues and I'll re-open this.

@yapret
Copy link

yapret commented Oct 12, 2017

Hi @ssddanbrown, I'm running the v0.18.3, and still seem to encounter this (or a very similar) problem.

I prefix page titles with words surrounded by brackets like [TRELLO], but can only find them when the said word is searched with quotes.

ssddanbrown added a commit that referenced this issue Oct 15, 2017
@ssddanbrown
Copy link
Member

@yapret Thanks for raising, Just about to deploy a release that splits on more characters include brackets.

After updating to v0.18.4 you'll need to regenerate the search index to see the effects:

php artisan bookstack:regenerate-search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants