Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(recently updated): show updatedBy and updated_at #3177

Merged
merged 1 commit into from
Jan 24, 2022
Merged

enh(recently updated): show updatedBy and updated_at #3177

merged 1 commit into from
Jan 24, 2022

Conversation

bourdaisj
Copy link
Contributor

See #3045 for informations

@bourdaisj bourdaisj force-pushed the show_more_informations_on_recently_updated_pages branch 2 times, most recently from bf34136 to 259d499 Compare January 18, 2022 22:13
@mlipok
Copy link

mlipok commented Jan 18, 2022

I just sent it to my WebDev to check this.

@bourdaisj bourdaisj force-pushed the show_more_informations_on_recently_updated_pages branch from 259d499 to 6db6476 Compare January 19, 2022 20:53
@bourdaisj bourdaisj marked this pull request as ready for review January 19, 2022 20:57
@mlipok
Copy link

mlipok commented Jan 20, 2022

It looks good for me:
image

@mlipok
Copy link

mlipok commented Jan 20, 2022

btw.
As you can see this shows only "Page" name for example "TYMCZASOWE" or "Screenshoty"
could you also think about adding a feature to provide more precise localization something like "Shelf / Book / Chapter / Page"

btw.
Should I open new FeatureRequest for this ?

@mlipok mlipok mentioned this pull request Jan 20, 2022
Closed
@bourdaisj
Copy link
Contributor Author

It may be out of scope for this PR but this could be a useful enhancement imo. Waiting for insights from the maintainers about this

@mlipok
Copy link

mlipok commented Jan 20, 2022

So I open new FeatureRequest

@mlipok mlipok mentioned this pull request Jan 20, 2022
Closed
@ssddanbrown ssddanbrown added this to the v21.12.3 milestone Jan 24, 2022
ssddanbrown added a commit that referenced this pull request Jan 24, 2022
@ssddanbrown
Added test to cover PR #3177
aae3cd6
@ssddanbrown ssddanbrown merged commit 6db6476 into BookStackApp:master Jan 24, 2022
@ssddanbrown
Copy link
Member

Thanks for this @Julesdevops, All looked great. I followed this up with a test to cover the change in aae3cd6.

Merged to be part of the next patch release.

@bourdaisj
Copy link
Contributor Author

Thanks, and apologies for the missing test, totally forgot for this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏭 Back-End 🛠️ Enhancement 💆 UX
Milestone
v21.12.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bourdaisj @mlipok @ssddanbrown