Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): add xdebug support for docker setup #3193

Merged

Conversation

bourdaisj
Copy link
Contributor

Add xdebug support in the docker compose setup.
Works well with my my setup (vscode), should work fine for other IDE as well.

If this looks good, I will provide documentation in the README.md and other relevant places (?).

@ssddanbrown
Copy link
Member

Thanks for this @Julesdevops,
Have tested on a PHPStorm setup and it seems to work well.

I did notice that the xdebug.start_with_request=yes which will activate xdebug on every request which will slow things down a bit when debugging. Probably notthing to worry about now but if people report slow development environments using the docker setup, this might need to change to be manually/extension initiated instead.

In regards to any documentation, keep it brief/high-level where possible. Don't want to fill the readme with instructions for each possible editor or anything.

@bourdaisj bourdaisj marked this pull request as ready for review January 23, 2022 13:30
@bourdaisj
Copy link
Contributor Author

@ssddanbrown Thx for feedback, I updated the readme.
Agree for the start_with_request option. I will be here to improve it if contributors reports slow development environments. :)

@ssddanbrown ssddanbrown added this to the v21.12.3 milestone Jan 24, 2022
@ssddanbrown ssddanbrown merged commit 6c699f7 into BookStackApp:master Jan 24, 2022
@ssddanbrown
Copy link
Member

Now merged, thanks again @Julesdevops

@esakkiraja100116
Copy link
Contributor

#4187 - Can you look at this issue @Julesdevops ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants