Portable ZIP Export Format #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all existing export related app files into their new own dir.
Also updated new route/view to new non-book-specific flow. Also fixed down migration of old export permissions migration.
Added syles for non-custom, non-image file inputs. Started planning out back-end handling.
Testing covers main UI access, and main non-successfull import actions. Started planning stored import model. Extracted some text to language files.
Split attachment service storage work out so it can be shared.
Reduced import data will now be stored on the import itself, instead of storing a set of totals.
Added file creation reverting and DB rollback on error. Added error display on failed import. Extracted likely shown import form/error text to translation files.
Fixed image size handling, and lack of attachment reference replacements during testing.
Images were missing their extension after import since it was (potentially) not part of the import data. This adds validation via mime sniffing (to match normal image upload checks) and also uses the same logic to sniff out a correct extension. Added tests to cover. Also fixed some existing tests around zip functionality.
And disable button after submit. Added here because the import could take some time, so it's best to show an indicator to the user to show that something is happening, and help prevent duplicate submission or re-submit attempts.
- Handled links to within-zip page images found in chapter/book descriptions; Added test to cover. - Fixed session showing unrelated success on failed import. Tested import file-create undo on failure as part of this testing.
- Updated test handling to create imports folder when required. - Updated some tests to delete created import zip files.
Added test to cover.
Adds an instance id via app settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
id_ciphertextproperty with newly generated internal ID (setting stored via migration?).Notes
Originally planned to add API endpoints as part of this, but think it's better to delay in case further changes/development need to be made.
Doc Updates