Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Oidc userinfo response Content-Type matching #5337

Merged

Conversation

wesbiggs
Copy link

@wesbiggs wesbiggs commented Nov 26, 2024

Updates the OIDC userinfo endpoint request to allow for a Content-Type response header with optional parameters, like application/json; charset=utf-8. This was causing an issue (failure to find a valid subject claim) when integrating with node-oidc-provider.

…pe` response header with optional parameters, like `application/json; charset=utf-8`. This was causing an issue when integrating with [node-oidc-provider](https://github.com/panva/node-oidc-provider).
@ssddanbrown ssddanbrown added this to the v24.10.2 milestone Nov 27, 2024
ssddanbrown added a commit that referenced this pull request Nov 28, 2024
@ssddanbrown ssddanbrown merged commit 17f7afe into BookStackApp:development Nov 28, 2024
1 check passed
@ssddanbrown
Copy link
Member

Thanks for this @wesbiggs, this might explain some previously unexplained scenarios that have been reported before!
I followed this up with bc1f1d9 just with a little extra value normalisation, and to add a test to cover.
Now merged to be part of the next patch release.

@wesbiggs
Copy link
Author

Great, thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants