Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#541 - Disable comments #593

Merged
merged 4 commits into from
Dec 7, 2017
Merged

#541 - Disable comments #593

merged 4 commits into from
Dec 7, 2017

Conversation

Abijeet
Copy link
Member

@Abijeet Abijeet commented Nov 15, 2017

Towards #541

Following has been done,

  1. Added an option under app settings - Disable comments
  2. If this is turned on then,
    1. Adding comments is disabled.
    2. Existing comments will not be shown.
    3. The entire comments section is removed and no message is shown stating that comments are disabled.

Two things are debatable here,

  1. Do we show a message stating that comments are disabled? Not sure if it's needed, but can be easily added.
  2. Do we show existing comments? I removed them to save an extra query to fetch the comments.

TODO

  • Add test cases for this option.

@Abijeet
Copy link
Member Author

Abijeet commented Nov 16, 2017

@ssddanbrown - I'm done with this change, please take a look and let me know if there is anything you'd like me to change/tweak.

@ssddanbrown ssddanbrown added this to the BookStack Beta v0.19.0 milestone Dec 4, 2017
@ssddanbrown ssddanbrown merged commit 6a54733 into BookStackApp:master Dec 7, 2017
@ssddanbrown
Copy link
Member

@Abijeet All looked great, I just renamed a variable but that's it. Thank you very much once again!

@ssddanbrown ssddanbrown mentioned this pull request Dec 7, 2017
@Abijeet Abijeet deleted the disable-comments branch December 8, 2017 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants