Skip to content

Conversation

@nwalke
Copy link
Contributor

@nwalke nwalke commented Feb 11, 2016

This might not be the best way to do this, but it certainly gets the job done.

Here's a gif of it in action: https://i.imgur.com/9mgpwHC.gif

@ssddanbrown ssddanbrown merged commit eacff3a into BookStackApp:master Feb 11, 2016
@ssddanbrown
Copy link
Member

Thanks again for the contribution! I changed the tree-list to be more of a full-screen sidebar as there were some issues when the tree list was taller than the page. I also changed some of the JS so it took into account the mobile widths and other breaking factors.

Here's a video of it now:
https://gfycat.com/TintedLastingEuropeanpolecat

I'm not fully set on it but I'll see how it feels in daily use.

@nwalke
Copy link
Contributor Author

nwalke commented Feb 11, 2016

Ah, perfect. I also realized my version was setting the CSS on every scroll action... probably not the best.

@nwalke nwalke deleted the book_nav_scroll branch February 11, 2016 22:49
@ErtugrulSueren ErtugrulSueren mentioned this pull request Apr 9, 2022
2 tasks
@Suddenflame Suddenflame mentioned this pull request May 26, 2022
2 tasks
@helson22 helson22 mentioned this pull request Nov 18, 2022
2 tasks
@Akalavolo Akalavolo mentioned this pull request Feb 26, 2024
2 tasks
@andym66 andym66 mentioned this pull request Mar 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants