-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draw.io integration #632
draw.io integration #632
Conversation
This looks good to me, I'll test this on my end once you are done. |
@@ -220,6 +220,124 @@ function codePlugin() { | |||
} | |||
codePlugin(); | |||
|
|||
function drawIoPlugin() { | |||
|
|||
const drawIoUrl = 'https://www.draw.io/?embed=1&ui=atlas&spin=1&proto=json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be user configurable in case a self-hosted version is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first it will not be as I don't really know how/if self-hosted instances provide the same level & ease of integration via a public url such as this. I doubt they would otherwise it could be used by anybody.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default self-hosted instance is a static one (check https://github.com/jgraph/drawio#running) which does not provide any integration (Google Drive, Dropbox, …). Also you must specify https=0
in query string if your own instance does not support TLS.
This lack of integration is not really important if files are saved as attachments inside Bookstack.
Also refactored ImageTests away from BrowserKit Also added image upload type validation.
Also updated image upload test to delete before upload to prevent failed tests breaking subsequent tests.
Okay, This is now complete with some basic tests to cover so will merge into master for next release. There's a couple of limitations with the current implementation:
|
Relates to #619.
Very much a WIP at time of creating pull request.
TODO