Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FromSlice and FromMap helpers in itx #127

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

BooleanCat
Copy link
Owner

@BooleanCat BooleanCat commented Jul 19, 2024

Please provide a brief description of the change.

Using itx.From(slices.Values(slice)) will be a fairly common pattern so this is to make that a bit less verbose with itx.FromSlice(slice) (and same for FromMap).

Which issue does this change relate to?

None.

Contribution checklist.

  • I have read and understood the CONTRIBUTING guidelines
  • All commits in my PR conform to the commit hygiene section
  • I have added relevant tests
  • I have not added any dependencies

Additional context

N/A.

@BooleanCat BooleanCat self-assigned this Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf660a4) to head (42b7a4d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          434       438    +4     
=========================================
+ Hits           434       438    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BooleanCat BooleanCat merged commit 3598419 into main Jul 19, 2024
6 checks passed
@BooleanCat BooleanCat deleted the itx-helpers branch July 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant