Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend arithmetic functions to support differential quantities #127

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

extend arithmetic functions to support differential quantities #127

wants to merge 1 commit into from
+1,405 −75

Conversation

rjnrohit
Copy link

@rjnrohit rjnrohit commented Apr 14, 2020 •
edited
Loading

Description

  1. Extended arithmetic functions to support differential quantities as well.
  2. Removed magnitude and unit_vector member function from base_differential.hpp
  3. Test for the above implementations has been added.

References

Fixes #125

@rjnrohit rjnrohit changed the title extend arithmetic functions to support for differential quantities extend arithmetic functions to support differential quantities Apr 14, 2020
This was referenced Apr 14, 2020
Open
Closed
@rjnrohit
Copy link
Author

@sarthak2007 I have created a separate PR as you suggested. you may wanna review it one more time.

@rjnrohit rjnrohit requested a review from sarthak2007 April 14, 2020 16:42
@rjnrohit
Copy link
Author

@sarthak2007 I have changed what you had requested. Now there is no conflict of differential argument get passed through make_cartesian_representation. Please have a look at the changes.

@rjnrohit rjnrohit requested a review from sarthak2007 April 23, 2020 01:02
@rjnrohit
Copy link
Author

rjnrohit commented Apr 23, 2020 •
edited
Loading

@sarthak2007 changes done! as you have suggested.@lpranam, please see this PR and provide your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarthak2007 sarthak2007 sarthak2007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rjnrohit @sarthak2007