Conversion Framework to convert between Coordinate Systems #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented conversion framework using Boost Graph Library for existing 5 Coordinate Systems. - Tests two convert from one node to another. - Generated PNG from dot file of the given graph.
lpranam
requested changes
Aug 28, 2020
| typename CoordinateType = double, | ||
| typename Angle = bu::quantity<bu::si::plane_angle, CoordinateType> | ||
| > | ||
| matrix<double> convert(const std::string& src, |
There was a problem hiding this comment.
As discussed on the call changing this to enum class is a better idea
…d to check for source destination validity.
lpranam
reviewed
Aug 30, 2020
| @@ -12,3 +12,7 @@ build-project header ; | |||
| build-project coordinate ; | |||
| build-project units ; | |||
| build-project io ; | |||
| build-project time ; | |||
There was a problem hiding this comment.
you should propose a new PR for this stating the problem.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Practical Astronomy with your Calculator or Spreadsheet Fourth Edition
Peter Duffett-Smith & Jonathan Zwart
Tasklist