Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying the link to an attachment should make sure that it is located in the same note folder #1924

Closed
ehhc opened this issue May 15, 2018 · 1 comment
Closed

Copying the link to an attachment should make sure that it is located in the same note folder #1924

ehhc opened this issue May 15, 2018 · 1 comment
Labels
bug 🐛 Issue concerns a bug.

Comments

@ehhc
Copy link
Contributor

ehhc commented May 15, 2018 •
edited
Loading

@Rokt33r we've discussed this today:

Steps

  1. Note 1 has an attachment
  2. Copy link to the attachment (-> [attachment1](:storage/attachments/notekey/attachment1)
  3. insert it into note 2
  4. delete note 1

Expected behavior

Attachment is still available in note 2

Current behavior

Attachment was deleted when note 1 was deleted -> it is not available anymore in note 2
@Rokt33r
Copy link
Member

Rokt33r commented May 16, 2018

Thanks for creating this issue!!

@Rokt33r Rokt33r added the bug 🐛 Issue concerns a bug. label May 16, 2018
ehhc added a commit to ehhc/Boostnote that referenced this issue May 21, 2018
@ehhc
Copying the link to an attachment should make sure that it is located…
0f96c52 
… in the same note folder -> Fixes BoostIO#1924
ehhc added a commit to ehhc/Boostnote that referenced this issue May 29, 2018
@ehhc
Copying the link to an attachment should make sure that it is located…
9c247bc 
… in the same note folder -> Fixes BoostIO#1924
@ehhc ehhc mentioned this issue May 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rokt33r @ehhc