Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo percentage not updated correctly... #2267

Closed
gufertum opened this issue Aug 7, 2018 · 7 comments
Closed

Todo percentage not updated correctly... #2267

gufertum opened this issue Aug 7, 2018 · 7 comments
Labels
bug 🐛 Issue concerns a bug.

Comments

@gufertum
Copy link

gufertum commented Aug 7, 2018

Current behavior

If you check off checkboxes in markdown view, the percentage does not update - only when using the rendered view. But switching to rendered view and ticking a checkbox still show the incorrect number... and sometimes the editor overwrites some characters instead of inserting text...

Expected behavior

Calculate the percentage correctly, regardless which view (renedered or markdown) is shown.

Steps to reproduce

  1. start with a fresh item checklist
  2. switch to rendered view
  3. check some checkboxes > still correct
  4. switch to markdown
  5. mark some checkboxes (add x) > the percentage does not update correctly and the editor starts overwriting "]" sometimes...

Environment

  • Version : 0.11.8
  • OS Version and name : OXS 10.13.5
@Rokt33r Rokt33r added the bug 🐛 Issue concerns a bug. label Aug 8, 2018
@ghost
Copy link

ghost commented Aug 11, 2018

I can not reproduce the problem. Did you use uppercase 'X' or had spaces in between?


  • Version : 0.11.9.pre
  • OS Version and name: 16.04 Ubuntu

@gufertum
Copy link
Author

Yes, uppercase, but I can't reproduce it consistently either. I need to edit around multiple times before it happens...

@ghost
Copy link

ghost commented Aug 11, 2018

there are no issues while using lowercase 'x'. when you use uppercase only check checkbox is updated. the bar is not updated with uppercase.

@ghost
Copy link

ghost commented Aug 12, 2018

I couldn't find an official source but the uppercase variant seems valid, too.
Here is a reference I found (unofficial). Most references I found are using lowercase.

Github supports both variants:

  • [x] lowercase 'x'
  • \[x]
  • \[x\]
  • [X] uppercase 'x'
  • \[X]
  • \[X\]

@ghost
Copy link

ghost commented Aug 18, 2018

I can fix it, should I fix it?

Rokt33r added a commit that referenced this issue Aug 20, 2018
@ghost
Copy link

ghost commented Aug 20, 2018

@Rokt33r, @gufertum
has been merged, can be closed.

@ghost
Copy link

ghost commented Sep 11, 2018

@ZeroX-DG fixed in 0.11.9. Issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug.
Projects
None yet
Development

No branches or pull requests

3 participants