-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files, Images get deleted automatically after dragging them on to boostnote interface. #3203
Comments
Thanks for reporting the issue! I have a few questions:
As for photoshop files I don't think Boostnote currently supports |
Not the note in question. But the image being dragged and dropped. After showing up for some time, it suddenly gets deleted from the storage folder. The time it takes to get deleted and the type of image is random. I am not saying to show the preview of photoshop file. But unlike any other file like doc, zip, or fla etc which atleast creates a link if not the preview, psd file does not even drop on the note's interface. That is, when a psd file is dropped no link is created. As if no file was ever dropped there. I hope I was clear. Thanks. :) |
See how it behaves when I try to upload psd files. In fact, it's doing the same with keynote files with extension (.key). However with key notes files there is a possibility that the application might be seeing it as a folder. Because keynote files are actually folders with .key extension, on mac. And boostnote does not allow putting folders as I understand. https://drive.google.com/open?id=1n13XpYMpXBWkRFVcTMAYVB-srb4zCHmK Another major problem as I said before is "content loss", the files disappear mysteriously. Today I copied a link from one storage folder to another storage folder. But on pasting it showed me a message that I am not allowed to paste it from another storage folder. That's fine. But when I tried to paste the file link back, it had already gone. And there was no Ctrl + z option. I tried to see it in recycle bin, but could not see anything there. My question: How do the files get deleted in this application? I suggest it should go to recycle bin, instead of overwriting. Because this leads to a major content loss issue. :) |
I looked into developer tools, and I saw some errors at main.js 7705: File "/mac-st./../..ign/notes/attachments/9fc24eea-5d9d-4f93-8644-36c3fe4fccc4/f8b47aff.png" deleted because it was not included in the content of the note What does that mean? I am not sure, but I don't remember I manually deleted anything from attachment folder. Does this give any pointers? My suggestion is you probably should not allow any type of deletion by the application. It can be disastrous in case there is some bug in algorithm. In a similar app called zim-notes, they just show the attachment folder as a side panel. So that the user always know the files available in the attachment folder, even if he deletes the link for some reason. |
As a temporary solution I searched Main.js in "compiled" folder and commented this section: files.forEach(function (file) { I hope files should not get deleted now. Not sure what side effects it may have. |
Thanks for the very detailed info! This should definitely help with understanding what is going on. I still can't quite reproduce the issue on Linux or Windows. From other reports/issues it might be a bug that is exclusive to Mac, which makes it a little more difficult to test. It might be caused by something like this, but this is merely a guess. The problem with "moving" an attachment from one note to another could be the following:
Do you also lose images (or file copies) if you haven't moved them between notes? |
Yes, that can be one of the reasons. That is the scenario when cutting and pasting from note to note, or note from one storage folder to another etc. But in many scenarios the files get deleted as soon as I drag from outside on to the note interface. Why this happens? And why is it selective about the type of file, as I said, it does not accept psd file. PS: Also this disappearance of files I have seen only with image files. I have not seen it with files of other extensions till now. |
From reading the issue, i thought about the same reason you describe as well... Unfortunately, i'm not able to reproduce mac issues because i don't have a private mac.. |
Hi there, Steps to Reproduce
Besides images, the issue happened on pdf file as well. Steps to Reproduce
EnvironmentBoostnote Version: 0.12.1 |
I'm seeing the same behavior. Boostnote Version: 0.12.1 |
I am troubled by the same problem |
I have so far been unable to reproduce this issue. I'm wondering if this might be due to my Boostnote storage folder being synced (with MEGA). @DemonElite @ronaldl @j892020 @VishwasGagrani Are any of you using any kind of automatic cloud saving of your notes? I don't expect it to make a difference, but I just want to make sure. The main reason this probably won't help is because the cloud saving should simply delete the file/attachment when Boostnote deletes it (even if Boostnote mistakenly does so). |
I've seen this behavior when syncing with OneDrive and pCloud. |
I am already using Google Drive. However the issue is related with Boostnote only. I have commented the line in Main.js of Boostnotes, and I have not faced any such problem after that. So if it's an emergency situation for any boostnote user, then you can do that temporary patching as I did, till this issue is solved completely. |
I was using Google Drive. After having the issue, I stop using cloud-saving and change the storage folder to a local one. The problem still exists, and then I report it here. |
I am facing the same issue, now using the workaround as well. I am not using Google Drive or OneDrive (or any other syncing application). |
This attachment files cleanup mechanism is annoying me since i've started using boostnote. I like the app, but i've lost so many attached files until I commented out these lines:
It could make some sense if the app would wait until it's closed or started next time to do cleanup things. Otherwise all copy/pasting/dragging operations are not safe for your data |
It annoyed you such a long time and you didn't think about creating a solution suitable for the other users as well...? Tbh: that's quite egoistic.. |
Not sure if #3225 can count as a proper fix for this issue. The behavior reported by many people here should not occur. Having the option to "disable" this bug by doing the process manually isn't a full fledged fix. It's a patch that provides a temporary solution as users have to enable the options themselves. Meaning that with default settings this issue will still occur. Reopening this issue until it is also fixed with default settings. Note that we could simply make the manual cleaning of attachments the default setting. Maybe add a warning when our detection says you have more than 1GB of unreferenced attachments. That way we no longer have this issue of deletion happening at the wrong time. |
I have exactly the same problem (Windows user here). My solution so far is to have Boostnote in Dropbox, so that when Boostnote randomly decides to delete some images I can go to Dropbox bin and restore them (since it does not delete them to the Bin using Windows bin is of no use). Commenting out those lines seems to work so far for me. |
I have a similar problem with images disappearing from my notes after a while and showing the broken image icon. They just disappear, they're not in the recycle bin or anywhere else, they just vanish. |
Facing the same issue.
|
I'm very sorry to hear about your problems. Unfortunately, i have no idea how i can try to solve a problem that only happens "randomly".. |
Thanks for your concern. A temporary fix for everyone would be to keep your notes folder under a git repo, and commit every now and then. |
This issue still exists at least on macOS Catalina 10.15.2 with background sync to OneDrive. Solution is to restore the deleted files in the OneDrive bin which is (obviously) very annoying. I disabled the "Delete files if not referenced anymore" for now to experiment if this solves the problem somehow. |
The developers are updating boostnote but not able to sort out this crucial problem. This is a very serious issue. I have to comment the particular section on every update of boostnote. |
@AndrinGautschi I don't think it'll make a difference 😞 |
It's working for me. |
@VishwasGagrani @AndrinGautschi Let's continue this discussion in #3424 |
Current behavior
Let us know what is currently happening.
When dragging and dropping the files and images, it gets deleted automatically after some time. It does not happen always, but it happens say 30% of the times. The file cannot even be seen in recycle bin. For some reason, I am never able to put files with "psd" extension (photoshop files ) on boostnote. It does not even accept it. The issue is very similar to this link: #1788 . Since it says it's solved, I am submitting the issue again.
Expected behavior
The file should not get deleted. It should remain in the folder like any other files.
Steps to reproduce
Environment
The text was updated successfully, but these errors were encountered: