Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ZZ work in vim mode #1041

Merged
merged 1 commit into from
Nov 15, 2017
Merged

make ZZ work in vim mode #1041

merged 1 commit into from
Nov 15, 2017

Conversation

machellerogden
Copy link
Contributor

As an avid vim user, I often use "ZZ" while in normal mode to quickly save and exit. This PR makes that bit of vim functionality work in Boostnote as well.

@kazup01
Copy link
Member

kazup01 commented Oct 31, 2017

Thanks for your contribution @machellerogden ! This feature is looks good.
Could you fix CI error?

@machellerogden
Copy link
Contributor Author

I'll check it out and update. Won't have time to loop back around to this until next week though. Thanks for your consideration!

@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 7, 2017
@kazup01 kazup01 self-requested a review November 15, 2017 04:46
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 8884db8 into BoostIO:master Nov 15, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 15, 2017

Merged. I will fix CI error soon. Thank you for your contribution @machellerogden :)

@kazup01 kazup01 added next release (v0.8.17) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. Next Release labels Nov 15, 2017
@kazup01 kazup01 mentioned this pull request Nov 15, 2017
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants