Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix solarized dark/light code block thema bug #1061

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Conversation

yosmoc
Copy link
Member

@yosmoc yosmoc commented Nov 4, 2017

fix #1060

solarized dark/light shares the same css in CodeMirror.
You can see more detail info in commit 5b17808
We need to treat solarized as a special case in code block also.

solarized dark/light shares the same css in CodeMirror.
You can see more detail info in commit 5b17808
We need to treat solarized as a special case in code block also.
@kazup01 kazup01 requested a review from sota1235 November 4, 2017 04:05
@kazup01
Copy link
Member

kazup01 commented Nov 4, 2017

Thank you for your contribution @yosmoc ! We will check it.

Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 993cb9c into BoostIO:master Nov 4, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 4, 2017

Merged. Thank you for your contribution @yosmoc 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solarized-dark theme not working
4 participants