electron-prebuilt is obsolete. use latest electron instead #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @yosmoc ! I will ask others it, wait a moment :) |
kohei-takata
approved these changes
Nov 14, 2017
kazup01
added
next release (v0.8.17)
and removed
awaiting review ❇️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I investigate the #1090 problem, but unfortunately, I couldn't reproduce the problem.
According to this thread electron/electron#9616, it has already been fixed in electron 1.6.x. So, I update electron to latest stable version.
And electron-prebuilt is obsolete. So I use latest electron instead.
I have built in Ubuntu 17.10 in my Virtualbox and it seems working fine.
Would some one try this PR?