store correct window size on Linux #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whizark
changed the title
|
@whizark |
|
Thank you @whizark , we will merge it at sometime soon. |
|
Merged. Thanks @whizark ;) |
|
@sosukesuzuki, @kazup01 Thank you for your review & merge! BTW, the new design on v0.8.17 is really cool 😄 |
kazup01
added
next release (v0.8.18)
and removed
awaiting review ❇️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boostnote ~never stores~~ always resets the window size on Ubuntu.
I noticed that
mainWindow.getBounds()instoreWindowSize(), which is called onwindow-all-closedevent (lib/main-window.js), always returns{ x: 0, y: 0, width: 0, height: 0 }.Handling
before-quitevent orwill-quitevent doen't fix either.I'm not sure if this makes sense but
storeWindowSize()oncloseevent works.Environment
Related commits
Just for reference, this or #1168 should fix #1166 😃