export folder as md or text #1147
Conversation
|
Hi @mslourens , thanks for your contribution! Could you fix CI error? |
kazup01
added
the
awaiting changes 🖊️
|
two tests are still failing (one of them is mine), but I don't know why, because on my local machine they both pass (both on Ubuntu and Windows 10). |
|
Hi @mslourens , sorry for long absence! |
|
@kazup01 no problem, I fixed the conflicts |
browser/main/SideNav/StorageItem.js
Outdated
| @@ -10,6 +10,7 @@ import dataApi from 'browser/main/lib/dataApi' | |||
| import StorageItemChild from 'browser/components/StorageItem' | |||
| import eventEmitter from 'browser/main/lib/eventEmitter' | |||
| import _ from 'lodash' | |||
| const path = require('path') | |||
browser/main/SideNav/StorageItem.js
Outdated
| label: 'Unlink Storage', | ||
| click: (e) => this.handleUnlinkStorageClick(e) | ||
| })) | ||
| let menu = Menu.buildFromTemplate([ |
There was a problem hiding this comment.
btw, using Menu.buildFromTemplate is so nice :)
| * exportDir: String | ||
| * } | ||
| * ``` | ||
| */ |
There was a problem hiding this comment.
thank you for your jsdoc 🙏
| const resolveStorageData = require('./resolveStorageData') | ||
| const resolveStorageNotes = require('./resolveStorageNotes') | ||
| const path = require('path') | ||
| const fs = require('fs') |
| .forEach(snippet => { | ||
| const notePath = path.join(exportDir, `${snippet.title}.${fileType}`) | ||
| console.log(notePath) | ||
| fs.writeFile(notePath, snippet.content, (err) => { |
There was a problem hiding this comment.
this will work as an async function
please handle it or use fs.writeFileSync
| }) | ||
| } | ||
|
|
||
| module.exports = exportFolder |
There was a problem hiding this comment.
please use export default
|
I fixed most of the review comments, except the last one: if I use export default the index.js in the dataApi folder, where this file is required, will fail, because it won't load the correct file. Or do I something wrong? |
|
Merged. Thanks @mslourens ! I will fix CI error soon. |
kazup01
added
next release (v0.8.20)
and removed
awaiting changes 🖊️
implemented #1122