Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note design #1161

Merged
merged 5 commits into from
Nov 24, 2017
Merged

Update note design #1161

merged 5 commits into from
Nov 24, 2017

Conversation

ytk141
Copy link
Contributor

@ytk141 ytk141 commented Nov 23, 2017

Update Note Detail style

boostnote notedetail design update copy

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@kazup01 kazup01 self-requested a review November 23, 2017 14:01
@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 23, 2017
@ytk141
Copy link
Contributor Author

ytk141 commented Nov 24, 2017

@kazup01 Updated style as you requested

@kazup01
Copy link
Member

kazup01 commented Nov 24, 2017

Thank @ytk141 ! I will check it soon ;)

Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 804991b into BoostIO:master Nov 24, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 24, 2017

Merged. I will fix CI error soon. Thanks @ytk141 🎉

@kazup01 kazup01 added next release (v0.8.17) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. Next Release labels Nov 24, 2017
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
@peci1
Copy link

peci1 commented Nov 25, 2017

Sorry, but I don't like this. Could there be an option for it?

@himaanshu24
Copy link

Now there is more whitespace present on both side of the note, wasting large area to take note. Also, this issue #1091 is still not fixed.

@ShreyasAiyar
Copy link

Hi could we have an option to toggle this feature?
For some of us with smaller screen sizes it is very not convenient.

@kazup01
Copy link
Member

kazup01 commented Nov 25, 2017

There is none option, but we will improve the layout by the next update. Wait a moment.
#1173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants