Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a specific style for checked inputs #1194

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Add a specific style for checked inputs #1194

merged 2 commits into from
Dec 4, 2017

Conversation

fabien0102
Copy link
Contributor

image

A really small PR to have a better style on checked items (before on the left). Simple but easier to find uncompleted items in a todo list 😉

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@kazup01
Copy link
Member

kazup01 commented Nov 27, 2017 •
edited
Loading

Hi @fabien0102 , thanks for your awesome suggestion!
I like this feature, but would like to hear feedback from others for a while.
Wait a moment to merge :)

@kazup01 kazup01 added the discussion 💬 Issue concerns a discussion. label Nov 27, 2017
@yamash723
Copy link
Contributor

So nice! I favor a this feature.

👍

@PascalAOMS
Copy link

Personally I'd leave out the italic font style.

When I cross out text on a piece of paper, it doesn't magically become italic, therefore it looks kinda odd to me.

@kazup01
Copy link
Member

kazup01 commented Nov 28, 2017

Poll on twitter 😄
https://twitter.com/Boostnoteapp/status/935359353376219136

@fabien0102
Copy link
Contributor Author

@PascalAOMS It's true, depends of your paper of course, but true ;) I can remove the italic style 😉

@fabien0102
Copy link
Contributor Author

fabien0102 commented Nov 28, 2017 •
edited
Loading

The updated screenshot:
image

@fabien0102
Copy link
Contributor Author

And the white version:
image

@kazup01
Copy link
Member

kazup01 commented Nov 29, 2017

Cool 😄

@kazup01 kazup01 requested a review from sosukesuzuki December 2, 2017 08:30
@kazup01 kazup01 added awaiting review ❇️ Pull request is awaiting a review. and removed discussion 💬 Issue concerns a discussion. labels Dec 2, 2017
sosukesuzuki
sosukesuzuki approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabien0102 !
Thank you for your contribution!
The checkbox style which you made is so cool! 👍
LGTM!! 😄

@kazup01 kazup01 merged commit e6db284 into BoostIO:master Dec 4, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 4, 2017

Merged. Thank you for your suggestion @fabien0102 ;)

@kazup01 kazup01 mentioned this pull request Dec 4, 2017
Closed
@kazup01 kazup01 added next release (v0.8.19) and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 6, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabien0102 @BoostnoteBot @kazup01 @yamash723 @PascalAOMS @sosukesuzuki