Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixbug react code mirror #1218

Merged
merged 4 commits into from
Dec 2, 2017
Merged

Conversation

PaulRosset
Copy link
Contributor

Hi :)

  • Bug fix

React-codemirror library produced a bug with the loadModule() method.

The mini editor inside the UI tab was not highlighted when the component was mount for the first time due to an error with react-codemirror.
capture d ecran 2017-12-01 a 16 42 11

@kazup01 kazup01 requested a review from sosukesuzuki December 2, 2017 02:07
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 2, 2017
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About a year ago, it was me who implemented it.
I was aware of the bug, but I could not fix it.
Thank you! LGTM !! 😄 👍

@kazup01 kazup01 merged commit b2b2373 into BoostIO:master Dec 2, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 2, 2017

Thank you @PaulRosset ;)

@kazup01 kazup01 added next release (v0.8.18) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Dec 2, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants