show delete confirmation dialog #1324
Conversation
|
Be sure to be changed |
|
@mslourens What do you think about shortening the message to simply "Move the note to the trash?" and changing the "Confirm" button text to "Move" for the sake of simplictity? Also do you think that there is maybe some way to de-duplicate the code without any major refactoring? |
|
Hi @mslourens , thanks for your support . Could you fix CI error? https://travis-ci.org/BoostIO/Boostnote/jobs/319797454 |
kazup01
added
awaiting changes 🖊️
|
|
||
| if (isTrashed) { | ||
| const dialogueButtonIndex = dialog.showMessageBox(remote.getCurrentWindow(), { |
There was a problem hiding this comment.
dialog is never used.
I think import is unnecessary on line 31.
| }, () => { | ||
| this.save() | ||
| }) | ||
| } | ||
| } | ||
| ee.emit('list:next') |
There was a problem hiding this comment.
I want you to make don't call ee.emit('line:next') when I push cancel.
(please fix it too on SnippetNoteDetail.js.)
|
sorry for the delay, I haven't been working for some time, because of the holidays. |
| @@ -28,7 +28,6 @@ import striptags from 'striptags' | |||
|
|
|||
| const electron = require('electron') | |||
| const { remote } = electron | |||
There was a problem hiding this comment.
remote and electron are unnecessary.
| } | ||
| } | ||
| ee.emit('list:next') | ||
|
|
There was a problem hiding this comment.
please remove this blank line.
|
Sorry for delay. |
|
Merged. Thanks @mslourens ! |
kazup01
added
next release (v0.8.20)
and removed
Next Release
awaiting changes 🖊️
implements #1320