Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug happen on solarized-dark CreateFolderModal. #1384

Merged
merged 3 commits into from
Jan 13, 2018
Merged

fix bug happen on solarized-dark CreateFolderModal. #1384

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc96873
add colors for SolarizedDark
sosukesuzuki Jan 11, 2018
1480986
change submit button style
sosukesuzuki Jan 11, 2018
7771875
Change CreateFolderInput style from raw color code to variable
sosukesuzuki Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions browser/main/modals/CreateFolderModal.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,29 @@ body[data-theme="dark"]

.control-confirmButton
colorDarkPrimaryButton()

body[data-theme="solarized-dark"]
.root
modalSolarizedDark()
width 500px
height 270px
overflow hidden
position relative

.header
background-color transparent
border-color $ui-dark-borderColor
color $ui-solarized-dark-text-color

.control-folder-label
color $ui-solarized-dark-text-color

.control-folder-input
border 1px solid #C9C9C9 // TODO: use variable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be best to add the color to variable now while you at it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for telling it me.
I'll fix it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 7771875

color white

.description
color $ui-inactive-text-color

.control-confirmButton
colorSolarizedDarkPrimaryButton()
10 changes: 9 additions & 1 deletion browser/styles/index.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,4 +339,12 @@ $ui-solarized-dark-button-backgroundColor = #002b36
$ui-solarized-dark-button--active-color = #93a1a1
$ui-solarized-dark-button--active-backgroundColor = #073642
$ui-solarized-dark-button--hover-backgroundColor = lighten($ui-dark-backgroundColor, 10%)
$ui-solarized-dark-button--focus-borderColor = lighten(#369DCD, 25%)
$ui-solarized-dark-button--focus-borderColor = lighten(#369DCD, 25%)

modalSolarizedDark()
position relative
z-index $modal-z-index
width 100%
background-color $ui-solarized-dark-backgroundColor
overflow hidden
border-radius $modal-border-radius