Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from preview to edit by double click #1543

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

nlopin
Copy link

@nlopin nlopin commented Feb 13, 2018

User want to click markdown to work with text (for example copy).
If they have "Switch to Preview" setting in "When Editor Blurred",
they enter edit mode after click. To fix that issue I introduced new
value to the "Switch to Preview" setting that do that thing. User can
enter edit mode by double click on the editor and leave it on blur.

Unfortunately, it's impossible to switch both ways by double click
because the editor mode is listening for double click event.

#1523

User want to click markdown to work with text (for example copy).
If they have "Switch to Preview" setting in "When Editor Blurred",
they enter edit mode after click. To fix that issue I introduced new
value to the "Switch to Preview" setting that do that thing. User can
enter edit mode by double click on the editor and leave it on blur.

Unfortunately, it's impossible to switch both ways by double click
because the editor mode is listening for double click event.

BoostIO#1523
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Feb 14, 2018
@sosukesuzuki sosukesuzuki self-requested a review February 19, 2018 06:39
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@kazup01 kazup01 merged commit 46a733b into BoostIO:master Feb 19, 2018
@kazup01
Copy link
Member

kazup01 commented Feb 19, 2018

Merged. Thanks for your contribution @nlopin !

@kazup01 kazup01 added next release (v0.9.1) and removed awaiting review ❇️ Pull request is awaiting a review. next release (v0.10.0) labels Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants