Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selector to sort tags by counter or alphabetically #1742

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Add selector to sort tags by counter or alphabetically #1742

merged 3 commits into from
Apr 10, 2018

Conversation

bimlas
Copy link
Contributor

@bimlas bimlas commented Mar 24, 2018

screencast

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 25, 2018
@Rokt33r Rokt33r self-requested a review March 25, 2018 16:17
@Rokt33r
Copy link
Member

Rokt33r commented Mar 25, 2018 •
edited
Loading

I like this feature. And, I want to suggest a little layout change.

Current layout:

Tags
↓alphabetically
#a
#b

Suggestion:

Tags ↓alphabetically
#a
#b

How do you think?

@bimlas
Copy link
Contributor Author

bimlas commented Mar 25, 2018 •
edited
Loading

It would be OK, but I'm working on another feature related to tags which needs control buttons, thus I think that the same layout can be used as the control of note list.

2018-03-25_203818

@Rokt33r
Copy link
Member

Rokt33r commented Mar 25, 2018

What kind of buttons are you going to add for tags?

@bimlas
Copy link
Contributor Author

bimlas commented Mar 26, 2018 •
edited
Loading

See #1756 - I moved to comments there.

@bimlas
Copy link
Contributor Author

bimlas commented Mar 26, 2018

Moved the selector next to the title:

2018-03-26_15-43-43

bimlas
bimlas commented Mar 27, 2018
View reviewed changes
browser/main/SideNav/SideNav.styl
display flex
height 30px
line-height 25px
overflow hidden
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct way to hide the selector when the sidebar is too narrow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. :)

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 4, 2018
@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Apr 6, 2018
@Rokt33r Rokt33r requested review from sosukesuzuki and removed request for Rokt33r April 10, 2018 07:52
sosukesuzuki
sosukesuzuki approved these changes Apr 10, 2018
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:smile:

@Rokt33r Rokt33r merged commit 65e77e9 into BoostIO:master Apr 10, 2018
@Rokt33r Rokt33r added next release (v0.12.0) and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 10, 2018
@bimlas bimlas deleted the order-of-tags branch April 11, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r left review comments

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bimlas @Rokt33r @sosukesuzuki @kazup01