Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update locales/zh-CN #1928

Merged
merged 10 commits into from
Jun 8, 2018
Merged

update locales/zh-CN #1928

merged 10 commits into from
Jun 8, 2018

Conversation

hooklife
Copy link
Contributor

No description provided.

@hooklife hooklife closed this May 18, 2018
@hooklife hooklife reopened this May 18, 2018
@kazup01 kazup01 requested review from kazup01 and removed request for kazup01 May 21, 2018 02:34
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 21, 2018
@kazup01 kazup01 added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Jun 4, 2018
@kazup01
Copy link
Member

kazup01 commented Jun 4, 2018

Thanks @hooklife for your contribution.
Is there anyone who can review it in Chinese?

@ChenLiZhan
Copy link

ChenLiZhan commented Jun 6, 2018

@kazup01
I am glad to help for the Chinese part!

@kazup01
Copy link
Member

kazup01 commented Jun 6, 2018

Thanks @ChenLiZhan !

@kazup01 kazup01 added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 6, 2018
@kazup01
Copy link
Member

kazup01 commented Jun 6, 2018

Hi @hooklife , thanks for your contribution! Could you fix conflict?

Copy link

@ChenLiZhan ChenLiZhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hooklife
I left some comments. Please take a look 👍

"Setting up 3rd-party cloud storage integration:": "设置整合第三方云存储:",
"Cloud-Syncing-and-Backup": "云端同步和备份",
"Location": "路径",
"Select Folder": "选择目录",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] Does it seem to be better if using 选择文件夹 to differentiate with line 199?

"Create new folder": "创建新文件夹",
"Folder name": "文件夹名称",
"Create": "创建",
"Unlink Storage": "取消链接",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[IMO] "取消存储链接" looks more specific to me.

"Delete a snippet": "删除一个代码片段",
"This work cannot be undone.": "此操作无法撤销。",
"Help": "帮助",
"Hungarian": "Hungarian",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] I don't know where the word "Hungarian" used actually. Does it mean 匈牙利语 here?

@hooklife
Copy link
Contributor Author

hooklife commented Jun 7, 2018

@ChenLiZhan
thanks a lot,I've fixed it

Copy link

@ChenLiZhan ChenLiZhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hooklife
The changes look good to me. Thank you so much!

@Rokt33r Rokt33r added next release (v0.11.6) and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jun 8, 2018
@Rokt33r Rokt33r merged commit 8af50aa into BoostIO:master Jun 8, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Jun 8, 2018

@hooklife @ChenLiZhan Thanks for the contributing 💯 💯 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants