Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file list blinking on search #2065

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Fix file list blinking on search #2065

merged 2 commits into from
Jun 12, 2018

Conversation

shammasov-max
Copy link

#2063
Issue solved, with trick after the search input.
Here I avoid selected file blinking in the notes list.
Trying to estimate whic file would be selected after the search, before router triggers the file name.

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Jun 11, 2018
@sosukesuzuki
Copy link
Member

sosukesuzuki commented Jun 11, 2018

@Flaps please fix from eslint!
yarn run lint

@sosukesuzuki
Copy link
Member

I fixed from eslint!:+1:

@sosukesuzuki sosukesuzuki self-requested a review June 12, 2018 10:35
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contribution!:smile:
LGTM:+1:

@sosukesuzuki sosukesuzuki merged commit 8ee4dbb into BoostIO:master Jun 12, 2018
@sosukesuzuki sosukesuzuki added next release (v0.11.6) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants