Add Ctrl+I and Ctrl+B support to format text #2180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl+I Now toggle Italics Ctrl+B Now toggle Bold Note: If there is a newline between the selected text this wont work since codemirror doesn't wrap text with newline in them anyway
Rokt33r
added
awaiting changes 🖊️
Rokt33r
requested changes
Jul 17, 2018
browser/components/CodeEditor.js
Outdated
| @@ -153,8 +153,69 @@ export default class CodeEditor extends React.Component { | |||
| 'Cmd-T': function (cm) { | |||
| // Do nothing | |||
| }, | |||
| 'Ctrl-I': function(cm) { | |||
There was a problem hiding this comment.
For macOS, we have to implement this to Cmd-I and Cmd-B.
So, we have to extract the handler and make it work depending on OS.
Like the below:
'Cmd-I': function (cm) {
if (global.process.platform !== 'darwin') { return }
applyItalic(cm)
},
'Ctrl-I': function (cm) {
if (global.process.platform === 'darwin') { return }
applyItalic(cm)
}
browser/components/CodeEditor.js
Outdated
| cm.replaceSelection(newSelection) | ||
| } | ||
| }, | ||
| 'Ctrl-B': function(cm) { |
browser/components/CodeEditor.js
Outdated
| Enter: 'boostNewLineAndIndentContinueMarkdownList', | ||
| 'Ctrl-C': (cm) => { | ||
| console.log('here', cm) |
There was a problem hiding this comment.
Please remove this unnecessary logging
|
wokay done |
|
@Rokt33r I noticed this problem, Maybe we should replan Bootnote shortcuts?
Right now shorcuts used by Bootnote don’t have explict config file, maybe we could create keybindings.json for system use, and another keybindings.json file for user themselves to customize.
By do this , we can prevent shortcuts conflict, and user can know shortcuts clearly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl+I Now toggle Italics
Ctrl+B Now toggle Bold
Note: If there is a newline between the selected text this wont
work since codemirror doesn't wrap text with newline in them anyway