Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing Mermaid diagram's height #2340

Closed
wants to merge 2 commits into from
Closed

fixing Mermaid diagram's height #2340

wants to merge 2 commits into from

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 25, 2018 •
edited
Loading

This change allows to specify the desired height of the diagram (in percentage in vh).
It should be able to fix #2335.

For example:

```mermaid:50
graph TB
	c1-->c2
	c2-->c3
	c3-->c4
	c4-->c5
	c5-->c6
```

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 27, 2018
@daiyam
Copy link
Contributor Author

daiyam commented Sep 4, 2018 •
edited
Loading

Here is a screenshot of the change:

mermaid

@daiyam daiyam mentioned this pull request Sep 13, 2018
Merged
@daiyam
Copy link
Contributor Author

daiyam commented Sep 13, 2018

A better fix is available at #2394

@daiyam daiyam closed this Sep 13, 2018
@daiyam daiyam deleted the bug-2335 branch November 25, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mermaid diagrams don't resize in height
2 participants
@daiyam @kazup01