Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Polish translations #2363

Merged
merged 10 commits into from
Sep 15, 2018
Merged

Add Polish translations #2363

merged 10 commits into from
Sep 15, 2018

Conversation

Rxbsxn
Copy link
Contributor

@Rxbsxn Rxbsxn commented Sep 4, 2018 •
edited
Loading

I have added support for the Polish language

Done

  • Most parts of the applications were translated into Polish

Todo

  • Fix minor issues

@ZeroX-DG ZeroX-DG added help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels Sep 5, 2018
mbarczak
mbarczak suggested changes Sep 5, 2018
View reviewed changes
Copy link

@mbarczak mbarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice translation. Just one nitpick to review, and one small bug.

locales/pl.json Outdated Show resolved Hide resolved
locales/pl.json Outdated Show resolved Hide resolved
@Rxbsxn Rxbsxn force-pushed the add-polish-language branch from 79df524 to f420326 Compare September 5, 2018 20:37
@Rxbsxn
Copy link
Contributor Author

Rxbsxn commented Sep 5, 2018 •
edited
Loading

@mbarczak Could you check it once again?
Thanks @igorjuraszek for help 🥇

mbarczak
mbarczak suggested changes Sep 5, 2018
View reviewed changes
Copy link

@mbarczak mbarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my thoughts :

locales/pl.json Outdated Show resolved Hide resolved
locales/pl.json Outdated Show resolved Hide resolved
locales/pl.json Outdated Show resolved Hide resolved
locales/pl.json Outdated Show resolved Hide resolved
@igorjuraszek
Copy link
Contributor

@mbarczak changes applied

mbarczak
mbarczak approved these changes Sep 5, 2018
View reviewed changes
Copy link

@mbarczak mbarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rxbsxn
Copy link
Contributor Author

Rxbsxn commented Sep 10, 2018

@ZeroX-DG It's approved, can you change the label? Thanks

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels Sep 10, 2018
ZeroX-DG
ZeroX-DG requested changes Sep 10, 2018
View reviewed changes
locales/pl.json Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed next release (v0.11.10) labels Sep 10, 2018
@Rokt33r Rokt33r merged commit 480f515 into BoostIO:master Sep 15, 2018
@Rokt33r Rokt33r added next release (v0.11.10) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rokt33r Rokt33r Rokt33r left review comments

@ZeroX-DG ZeroX-DG ZeroX-DG requested changes

@mbarczak mbarczak mbarczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rxbsxn @igorjuraszek @mbarczak @Rokt33r @ZeroX-DG