-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing a context menu handler to show an attachment in the expl… #2418
Conversation
@ehhc |
@sosukesuzuki but your solution would break it on windows platform.. I will think about a platform independent solution :) Edit: i don't understand why it works at all.. your markdown content dosen't look like you inserted it as an attachment.. there the link in the markdown content should be something like |
@ehhc I tried to insert same file ( |
@sosukesuzuki in that case i have no idea why i dosen't work.. on my windows 10 it works .. :( no idea whats different.. |
@ehhc Umm..., I have no idea too. I'll put label "help wanted!". |
@sosukesuzuki i think the problem may be that i hard-coded the way i removed the file-prefix.. i'm using an library to do so now.. hopefully that solves the issue. Would you do me a huge favor and test it again? Steps to reproduce:
Thank you for your help :) |
I think the library i'm using now solves exactly your problem (that the paths are different on linux systems).. :) |
Confirm that it works on Linux Mint |
@ehhc Confirm that it works on my local environment!(MacOS 10.13.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:smile:
Thanks guys :) |
It would be nice to open the location of an attachment with the explorer -> Implementing a contextMenu in the MarkdownPreview to do this :)