Title will now be extracted from front matter if title: is present. #2510
Conversation
nagledb
force-pushed
the
nagledb-front-matter-title
branch
from
dc86600 to
7688631
Compare
|
I updated the PR: Added preferences to support toggling front matter title extraction on/off and to customize what field is used for the title. |
…n/off and to customize what field is used for the title.
nagledb
force-pushed
the
nagledb-front-matter-title
branch
from
7688631 to
3272033
Compare
| enableTableEditor: this.refs.enableTableEditor.checked | ||
| enableTableEditor: this.refs.enableTableEditor.checked, | ||
| enableFrontMatterTitle: this.refs.enableFrontMatterTitle.checked, | ||
| frontMatterTitleField: this.refs.frontMatterTitleField.value |
There was a problem hiding this comment.
I think you should trim() this string first. If I leave a leading blank space the title will be broken because <space>title != title and you should add test for that too 😃
There was a problem hiding this comment.
Hmm, I think that change would definitely make sense but I'm not sure where to add it. It doesn't look like any of the other fields do any kind of validation/cleanup currently either. For example, I can change "Editor Font Size" to "12a" and I can change "LaTeX Inline Open Delimiter" to " $ " (two leading and two trailing spaces).
I also don't see that there's any existing test infrastructure for the UI tab or for the underlying ConfigManager.
Maybe that kind of stuff should all be done as a separate set of changes?
There was a problem hiding this comment.
Hmm...I guess you're right. I approve your change and maybe open an issue for it.
ZeroX-DG
added
awaiting changes 🖊️
Rokt33r
added
next release (v0.11.11)
and removed
approved 👍
Builds on front matter changes introduced by #2347