Fixed "Save as HTML" to respect blockquotes. #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving as HTML, the raw text was being HTML escaped prior to running it through markdown. This was preventing blockquotes from rendering because greater-than signs were escaped. The HTML escaping seems unneeded since the markdown renderer already takes care of it, and it also wasn't consistent with how markdown was being rendered within the application.
nagledb
force-pushed
the
fix-blockquote-in-html-export
branch
from
b316301 to
5144c0e
Compare
ZeroX-DG
added
awaiting changes 🖊️
|
LGTM but I still need @Rokt33r to review this. |
I don't think it is true. Markdownit doesn't sanitize anything. But, I'm okay with discarding this because most of users open the exported html on the latest browser like Chrome. So, it should be fine for now. |
Rokt33r
added
next release (v0.11.12)
and removed
awaiting changes 🖊️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving as HTML, the raw text was being HTML escaped prior to
running it through markdown. This was preventing blockquotes from
rendering because greater-than signs were escaped. The HTML escaping
seems unneeded since the markdown renderer already takes care of it,
and it also wasn't consistent with how markdown was being rendered
within the application.
Fixes #1922
Fixes #2514