Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zoom Controls
The shortcuts follow the standard controls I have seen in popular apps like google chrome or spotify.
You may notice that I have bound the zoom in to
CommandOrControl+=
instead of the standardCommandOrControl+Plus
, this is due to an electron bug. I have posted a comment here. Feel free to check it out electron/electron#6731. The accelerator does the same thing so it has no effect on user experience.I've tested everything on macOS and it seems to be fine 👍
I need others to test on windows and linux please 🙏
Issue fixed
#2554
#2089
Type of changes
Checklist: