Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature 'saveTagsAlphabetically' #2756

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Fix feature 'saveTagsAlphabetically' #2756

merged 1 commit into from
Dec 27, 2018

Conversation

vienai8d
Copy link
Contributor

Description

saveTagsAlphabetically feature has been added in 8b4a9dd, but this feature removed by 4e80e1d. Both commits are in same PR #2314.
If this feature was valid, tags of a note would be saved in alphabetical order. However, in the latest version, the tags are saved in order of creation as below.

savetagsalphabetically_off

Now, I fix this feature and the tags are saved in alphabetical order as below.

savetagsalphabetically_onf

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rokt33r Rokt33r merged commit 3ab506e into BoostIO:master Dec 27, 2018
@vienai8d vienai8d deleted the saveTagsAlphabetically branch December 27, 2018 04:58
@vienai8d
Copy link
Contributor Author

THX!

@daiyam
Copy link
Contributor

daiyam commented Dec 27, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants