Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable updates in dev #2798

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Disable updates in dev #2798

merged 5 commits into from
Jan 23, 2019

Conversation

MiloTodt
Copy link
Contributor

App will no longer attempt to update whilst in development mode.
Follows guidelines from https://electronjs.org/docs/tutorial/updates

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 13, 2019
ZeroX-DG
ZeroX-DG requested changes Jan 13, 2019
View reviewed changes
lib/main-app.js Outdated Show resolved Hide resolved
lib/main-app.js Show resolved Hide resolved
@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 18, 2019
ZeroX-DG
ZeroX-DG reviewed Jan 19, 2019
View reviewed changes
lib/main-app.js Outdated Show resolved Hide resolved
ZeroX-DG
ZeroX-DG approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jan 22, 2019
Rokt33r
Rokt33r requested changes Jan 22, 2019
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late change request. 😭

lib/main-app.js Outdated Show resolved Hide resolved
@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 22, 2019
@Rokt33r Rokt33r merged commit c0f68dc into BoostIO:master Jan 23, 2019
@Rokt33r Rokt33r added next release (v0.11.13) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jan 23, 2019
@Rokt33r Rokt33r mentioned this pull request Feb 8, 2019
Closed
@MiloTodt MiloTodt deleted the disable-updates-in-dev branch March 15, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloTodt @Rokt33r @ZeroX-DG