Click a note link will now select the right folder note and not /home #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that will be selected
ZeroX-DG
requested changes
Mar 22, 2019
browser/main/NoteList/index.js
Outdated
| this.focusNote(selectedNoteKeys, noteHash, '/home') | ||
|
|
||
| let locationToSelect = '/home' | ||
| const notesByHash = data.noteMap.map((note) => note).filter((note) => note.key === noteHash) |
There was a problem hiding this comment.
Why don't you use find instead of filter? Can you explain it to me?
There was a problem hiding this comment.
@ZeroX-DG Thanks for your Feedback. I was inspired by the handleNoteClick function in NoteList/index.js. I've changed the code and using the find function to get the first note and not all notes that matching the key (which always will be one).
ZeroX-DG
added
the
awaiting changes 🖊️
ZeroX-DG
requested changes
Mar 22, 2019
Co-Authored-By: dredav <dredav@users.noreply.github.com>
@ZeroX-DG Thanks for you suggestion. I have applied it. |
ZeroX-DG
approved these changes
Mar 24, 2019
ZeroX-DG
added
approved 👍
Rokt33r
changed the title
Rokt33r
removed
the
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After following a link to an other note the folder /home (All Notes) will be selected. The expected behavior is that the storage folder of the requested note will be selected.
Screenshot before
Screenshot after
Type of changes
Checklist: