Add importer which imports files from .md/.txt #325
Conversation
|
Sorry, firstly plz fix conflicts 🙇 |
|
Alright. Done. |
|
How do I get this? It's not in the current download. |
|
@GaryFurash This feature is in progress now. So wait a moment please... 🙇 |
|
@asmsuechan Thanks. I'll check 💡 |
browser/main/NoteList/index.js
Outdated
| } | ||
|
|
||
| const targetIndex = _.findIndex(this.notes, (note) => { | ||
| return note != null && note.storage + '-' + note.key === location.query.key |
There was a problem hiding this comment.
Can't you use strict equal? !==
And you can use template literal.
| if (filepaths === undefined) return | ||
| filepaths.forEach((filepath) => { | ||
| fs.readFile(filepath, (err, data) => { | ||
| if (err) throw Error('File reading error: ', err) |
There was a problem hiding this comment.
[Question] Do you test this situation? Doesn't it crush?
There was a problem hiding this comment.
Umm, I tried by hand, but the probability is quite low.
|
Just an idea that is related to this....what about the ability to upload a ZIP archive file that contains multiple files of any of these formats,
Boostnote would then create a Code Snippet File in Boostnote and add a sub-file/tab file for each file in the ZIP archive that is in the allowed formats. Just an idea |
browser/main/NoteList/index.js
Outdated
| filepaths.forEach((filepath) => { | ||
| fs.readFile(filepath, (err, data) => { | ||
| if (err) throw Error('File reading error: ', err) | ||
| // TODO: fill the title |
There was a problem hiding this comment.
I'm gonna open another PR to implement a module for findTitle().
There was a problem hiding this comment.
I should use the method, so I have to wait for merging it.
#548
kazup01
added
the
awaiting changes 🖊️
asmsuechan
removed
the
awaiting changes 🖊️
|
Is this working yet? It doesn't work on my Windows 7 or Windows 10 PC. |
|
@GaryFurash I'm going to try fixing it in a few days. |
|
@GaryFurash Well, it seems to work fine in my environment (master branch on windows 10). Please open a new issue with screenshots. |
Hi there. I implemented a function which imports files from .md or .txt.
Specifications
If someone wants what else, please comment.
TODO
I'll implement
fill a titleafter #324 is merged.Future