Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALT key toggles the menu bar #339

Closed
wants to merge 3 commits into from
Closed

ALT key toggles the menu bar #339

wants to merge 3 commits into from

Conversation

klaudiosinani
Copy link

@klaudiosinani klaudiosinani commented Mar 19, 2017

Now it's possible to have the menu bar hidden when launching the app, and only toggling it whenever you need it, just by pressing the ALT key.

untitled-1

boostnote

@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 19, 2017

Hi @klauscfhq! Thanks for your PR. Could you remove the variable you deleted? https://travis-ci.org/BoostIO/Boostnote/jobs/212747642
Travis says error 'showMenu' is assigned a value but never used no-unused-vars.

I'd say it's a good feature. But I'd like to ask other opinions from other members.

@asmsuechan
Copy link
Contributor

Actually, I don't make sense this code @klauscfhq removed: var showMenu = process.platform !== 'win32'.
And I dug commits, I found this PR: #150. However, I don't have any ideas why he added this because it behaves only on mac thus it's useless. From these, I want to make a decision that it's his mistake to use ternary operator.

@klaudiosinani
Copy link
Author

klaudiosinani commented Mar 19, 2017

Sorry for that. Of course, happy to contribute to the app.

Update: It's common on electron apps to set as true the boolean value of the autoHideMenuBar attribute. I removed the showMenu variable since it was preventing Travis from successfully building.

@sota1235
Copy link
Contributor

Thanks for contributing :)
We'll consider about this feature. Because the points like below.

  • It is more smart design 🎨
  • But if the user don't know alt key feature, use can't never use menu bar features(export the note, confirm some information and etc...)

@sota1235 sota1235 added the discussion 💬 Issue concerns a discussion. label Apr 22, 2017
@meguroyama
Copy link

Hi any update on this ? I've asked a similar question on #537 seems like it is waiting for PR to be merged by collaborators.

@jasondavis
Copy link

This is a common feature among Windows apps to use the ALT key to toggle toolbar so I would say it's a good PR

@klaudiosinani
Copy link
Author

klaudiosinani commented May 20, 2017

@gotenyama @jasondavis You can add the feature to your local build just by switching the autoHideMenuBar: showMenu property to autoHideMenuBar: true, which is located inside the resources/app/lib/main-window.js file. It can be a temporary fix, until a better implementation is achieved, though you would still have to repeat it after an app update.

@klaudiosinani klaudiosinani deleted the feature-toggle-menu-bar branch June 22, 2017 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion 💬 Issue concerns a discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants