Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cm searchbox to official search addon #696

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Replace cm searchbox to official search addon #696

merged 2 commits into from
Jul 10, 2017

Conversation

asmsuechan
Copy link
Contributor

@asmsuechan asmsuechan commented Jul 9, 2017

I want to replace cm-searchbox to the official search addon because it's very hard to customize.

Pros

  • Easy to maintain
  • Easy to customize
  • Officially supported

Cons

  • Unintuitive behavior

ScreenShots

screen shot 2017-07-09 at 22 49 18

And vim-search is available (Look at the bottom of CodeEditor).
screen shot 2017-07-09 at 22 49 26

@asmsuechan asmsuechan merged commit 849aa05 into BoostIO:master Jul 10, 2017
@asmsuechan asmsuechan deleted the replace-cm-searchbox-to-official-search-addon branch July 10, 2017 05:21
@asmsuechan
Copy link
Contributor Author

asmsuechan commented Jul 20, 2017

ref: Add search-box: #686

@BobTB
Copy link

BobTB commented Sep 10, 2017

Is this included / released in the latest version? Without full text search the thing is almost useless.

@asmsuechan
Copy link
Contributor Author

@BobTB
Copy link

BobTB commented Sep 11, 2017

OK, it took me a while ti find it! It is only for searching the currently selected note. A really good search would be a single one, global for the whole app, which would filter the notes containing the searched string and at the same time showing it on the "edit" panel highlighted for the currently selected note. Search as you type thing is also good, not that I have to enter the search string and then hit enter for it to show the results.

Check out resophnotes ( http://resoph.com/ResophNotes/Welcome.html ), a 7 years old app, it has all of this and works just beautifully, this is how the search functionality should be implemented.

@dejafait
Copy link

+1 for having a global full-text search on snippet content as described by @BobTB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants