Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout #722

Merged
merged 7 commits into from
Jul 25, 2017
Merged

Fix layout #722

merged 7 commits into from
Jul 25, 2017

Conversation

kazup01
Copy link
Member

@kazup01 kazup01 commented Jul 24, 2017

I fixed following layout.

  • InfoTab
  • Export icon at InfoPanel
  • Overall button

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 requested a review from asmsuechan July 24, 2017 08:57
Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want a screenshot when you change styles.

<p>We collect only the number of users on Boostnote for DAU and any detail information<br />
such as a note's content or title is not collected.</p>
<p>You can see how it works on <a href='https://github.com/BoostIO/Boostnote'>GitHub</a></p>
<p>We collect only the number of DAU for Boostnote, NOT COLLECTED any detail information</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume and DO NOT COLLECT is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me again, the comma is not needed.

Copy link
Contributor

@asmsuechan asmsuechan Jul 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I now noticed that it's COLLECTED...

such as a note's content or title is not collected.</p>
<p>You can see how it works on <a href='https://github.com/BoostIO/Boostnote'>GitHub</a></p>
<p>We collect only the number of DAU for Boostnote, NOT COLLECTED any detail information</p>
<p>like your note content. You can see how it works on <a href='https://github.com/BoostIO/Boostnote' onClick={(e) => this.handleLinkClick(e)}>GitHub</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change such as to like?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mean. I turned back it to such as.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

@kazup01
Copy link
Member Author

kazup01 commented Jul 24, 2017

New UI
screen shot 0029-07-24 at 7 17 42 pm

Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@asmsuechan asmsuechan merged commit 0290d23 into master Jul 25, 2017
@asmsuechan asmsuechan deleted the fix-layout branch July 25, 2017 01:18
@asmsuechan asmsuechan mentioned this pull request Jul 25, 2017
@asmsuechan
Copy link
Contributor

Umm, it does not work fine.
image

@kohei-takata kohei-takata mentioned this pull request Jul 29, 2017
@kazup01 kazup01 mentioned this pull request Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants